[PATCH] D37317: [X86] Don't pull carry through X86ISD::ADD carryin, -1 if we can't guranteed we're really using the carry flag from the add.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 11:44:21 PDT 2017


craig.topper added inline comments.


================
Comment at: test/CodeGen/X86/pr34381.ll:11
+; Function Attrs: noinline nounwind optnone uwtable
+define void @_Z3foov() {
+; CHECK-LABEL: _Z3foov:
----------------
spatel wrote:
> Something's not right with this test - it passes on trunk already.
it requires slowincdec. Which i though 64-bit defaulted to, but it turns out clang defaults the target-cpu to x86-64 in 64-bit mode with no other information and that enables slowincdec. llc defaults it to "generic". There were attributes in the original IR that I stripped out to reduce size.


https://reviews.llvm.org/D37317





More information about the llvm-commits mailing list