[PATCH] D37314: Disable 64bit file position on old 32 bit Androids
Pirama Arumuga Nainar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 31 10:07:59 PDT 2017
pirama added a comment.
LGTM for Android, but I'll let other reviewers formally accept it, in case they have build-system centric comments.
In https://reviews.llvm.org/D37314#857392, @aoli wrote:
> Pirama: shall I remove `remove_definitions(-D_FILE_OFFSET_BITS=64)` in https://reviews.llvm.org/D35648? Or we don't want `FILE_OFFSET_BITS=64` for runtimes no matter what `ANDROID_NATIVE_API_LEVEL` is.
We should remove the line you mention above once this change goes in.
https://reviews.llvm.org/D37314
More information about the llvm-commits
mailing list