[llvm] r312246 - Revert r312240

Alex Lorenz via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 08:51:23 PDT 2017


Author: arphaman
Date: Thu Aug 31 08:51:23 2017
New Revision: 312246

URL: http://llvm.org/viewvc/llvm-project?rev=312246&view=rev
Log:
Revert r312240

The buildbots have shown that -Wstrict-prototypes behaves differently in GCC
and Clang so we should keep it disabled until Clang follows GCC's behaviour

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=312246&r1=312245&r2=312246&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Thu Aug 31 08:51:23 2017
@@ -581,8 +581,6 @@ if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPI
 
   # Enable -Wstring-conversion to catch misuse of string literals.
   add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
-  # Enable -Wstrict-prototypes to catch incorrectly declared functions in C.
-  add_flag_if_supported("-Wstrict-prototypes" STRICT_PROTOTYPES_FLAG)
 endif (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))
 
 if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT LLVM_ENABLE_WARNINGS)




More information about the llvm-commits mailing list