[PATCH] D37240: Fix crbug 759265 by suppressing llvm mt warnings.

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: lld/COFF/DriverUtils.cpp:431
+  std::string Msg = toString(InternalOutputBufferOrError.takeError());
+  if (Msg != "no libxml2")
+    fatal("error with internal manifest tool:" + Msg);
----------------
I suppose this will solve the immediate problem, but it still looks a bit strange.

I'm not very familiar with this code, but don't we know beforehand if the internal mt tool is available and expected to work?

As Rui pointed out, why can't we just do:

```
If the internal mt is present:
  If merge fails for some reason:
    Report that error and abort
Otherwise:
  Invoke external mt command, and if it fails, abort
```


https://reviews.llvm.org/D37240