[PATCH] D37265: [SCEV] Ensure ScalarEvolution::createAddRecFromPHIWithCastsImpl properly handles out of range truncations of the start and accum values

[Daniel Neilson via Phabricator via llvm-commits]

dneilson added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:4509
+                              const SCEV *ExtendedExpr) -> bool {
+#if defined(OPTION_1)
+    return isa<SCEVConstant>(Expr) && Expr != ExtendedExpr;
----------------
Any thoughts on which option we should go with for this check? Should we limit to just the constant case (option 1), or go for more general (& expensive) with isKnownPredicate()? 


https://reviews.llvm.org/D37265