[PATCH] D28249: Improve scheduling with branch coalescing

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 22:50:03 PDT 2017


On Fri, Apr 28, 2017 at 8:00 AM Lei Huang via Phabricator <
reviews at reviews.llvm.org> wrote:

> lei added a comment.
>
> > I think most passes have a cl::opt in `TargetPassConfig.cpp` instead and
> we don't even add the pass the pipeline if it is disable, you could change
> to that style too to avoid people seeing the dump for a disabled pass :)
>
> Will address this in the next patch to turn this on by default for PowerPC.
>

>From looking at this it's already turned on by default.

Since this was unintended I'm going to go ahead and revert for now and then
we can add it back in turned off and then turn it back on after the
existing issues are fixed.

Thanks!

-eric


> Thanks
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D28249
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170831/558dd6be/attachment.html>


More information about the llvm-commits mailing list