[PATCH] D37311: [DebugInfo] Lower dbg.declare to DBG_VALUE with DW_OP_deref

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
Herald added a subscriber: hiraditya.

This is a step towards eliminating the vestigial second operand of
DBG_VALUE, which is always an immediate zero or noreg and only indicates
if the debug value is indirect in memory. Today, the offset is carried
in the DIExpression, and soon the indirection will live there too.

Many of the test case updates remove DW_OP_deref to better match the IR
that clang generates after r300523, which removed DW_OP_deref from VLAs
and indirect parameters.


https://reviews.llvm.org/D37311

Files:
  llvm/include/llvm/CodeGen/SelectionDAG.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp
  llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
  llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/test/DebugInfo/COFF/pieces.ll
  llvm/test/DebugInfo/COFF/types-array-advanced.ll
  llvm/test/DebugInfo/X86/dbg-declare-arg.ll
  llvm/test/DebugInfo/X86/debug-loc-asan.ll
  llvm/test/DebugInfo/X86/dw_op_minus.ll
  llvm/test/DebugInfo/X86/op_deref.ll
  llvm/test/DebugInfo/X86/safestack-byval.ll
  llvm/test/DebugInfo/X86/vla.ll
  llvm/test/DebugInfo/X86/vla2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37311.113313.patch
Type: text/x-patch
Size: 26727 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170830/dd18e3d9/attachment-0001.bin>