[PATCH] D37276: [yaml2obj][ELF] Make symbols optional for relocations

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 14:16:43 PDT 2017


silvas accepted this revision.
silvas added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/tools/yaml2obj/invalid-symboless-relocation.yaml:1
+# This test should sucseed but produces an invalid relocation. This test
+# documents this behavoir.
----------------
small wording nit: "should succeed" -> "succeeds", otherwise it isn't clear whether "should" implies "we don't do it now, but it should" and requires some context to disambiguate.


Repository:
  rL LLVM

https://reviews.llvm.org/D37276





More information about the llvm-commits mailing list