[PATCH] D33638: [libcxx] Have separate abi library flags for static and shared builds

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

@martell - I forgot to look at this patch - I've been experimenting with the same, with building libc++ and libc++abi for mingw now.

Full static builds run fine (requiring quite a bit of cmake fiddling though, and a few minor patches that I've sent separately now, that I see that you've fixed similarly more or less here, bundled up into the big change), but the shared builds fail with some symbols that aren't properly dllexported/imported across the border between libc++ and libc++abi. Did you run into the same issues, and are they fixed by doing what you suggest here (linking in libc++abi statically into libc++.dll)? To do this, did you need to build libc++abi with some extra cmake flags, like _LIBCPP_BUILDING_LIBRARY, to pretend it's all part of the same library build?


Repository:
  rL LLVM

https://reviews.llvm.org/D33638