[PATCH] D36862: AMDGPU: Handle non-temporal loads and stores

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 30 12:04:34 PDT 2017


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMemoryLegalizer.cpp:115
+    MachineOperand &Bit = MI->getOperand(BitIdx);
+    if (Bit.getImm() == 1)
+      return false;
----------------
It would be better to check if != 0. If you define an operand as an i1imm for example it is the sign extended constant value -1


https://reviews.llvm.org/D36862





More information about the llvm-commits mailing list