[PATCH] D36792: [AArch64] v8.3-a complex number support

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrFormats.td:9488
+let mayLoad = 0, mayStore = 0, hasSideEffects = 0 in
+class BaseSIMDThreeSameVectorTiedComplex<bit Q, bit U, bits<2> size,
+                                         bits<3> opcode,
----------------
Do you think it's worth making a base class for BaseSIMDThreeSameVectorTiedComplex and BaseSIMDThreeSameVectorComplex?


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.td:462
+// v8.3a complex add and multiply-accumulate. No predicate here, that is done
+// inside the multiclass as the F16 versions need different predicates.
+defm FCMLA : SIMDThreeSameVectorTiedComplexHSD<1, 0b110, complexrotateop,
----------------
Nit: F16 => FP16?


https://reviews.llvm.org/D36792