[PATCH] D34863: [XRay][tools] Function call stack based analysis tooling for XRay traces

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 23:44:51 PDT 2017


dberris added inline comments.


================
Comment at: tools/llvm-xray/xray-stacks.cc:298-301
+  // The key into ThreadIdFuncIdIndex is a concatenation of thread id and
+  // function id into a 64 bit value.
+  // TODO: This is filled out, but not put to use. What's the use case for it?
+  DenseMap<uint64_t, SmallVector<TrieNode *, 4>> ThreadIdFuncIdIndex;
----------------
This is a remnant of an earlier implementation. I forget now what I was thinking. :)


https://reviews.llvm.org/D34863





More information about the llvm-commits mailing list