silvas added a comment. Seems pretty straightforward. LGTM. Also it's probably good to add a test documenting what happens when you have a relocation that does need a symbol but you don't provide one. Repository: rL LLVM https://reviews.llvm.org/D37276