[PATCH] D36255: Integrate manifest merging library into LLD.

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: lld/trunk/COFF/DriverUtils.cpp:432
+                  [&](ErrorInfoBase &EIB) {
+                    warn("error with internal manifest tool: " + EIB.message());
+                  });
----------------
I'm not sure it makes sense to warn here. The user probably doesn't care which way the manifests were merged?

This breaks Chromium's build with LLD on Windows since libxml2 isn't availalbe and we treat warnings as errors. See https://bugs.chromium.org/p/chromium/issues/detail?id=760385


Repository:
  rL LLVM

https://reviews.llvm.org/D36255