[PATCH] D37251: [X86] Add a pass to convert instruction chains between domains

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86DomainReassignment.cpp:494
+    for (int OpIdx = 0; OpIdx < OpEnd; ++OpIdx) {
+      if (OpIdx == MemOp) {
+        // skip address calculation.
----------------
delena wrote:
> I think that you can iterate to MemOp. After the MemOp may be only immediate.
There are definitely instructions that have a register after the memory op. For example vpblendvb


https://reviews.llvm.org/D37251