[PATCH] D37279: [codeview] make DbgVariableLocation::extractFromMachineInstruction use Expected

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 15:02:52 PDT 2017


inglorion created this revision.
Herald added a subscriber: hiraditya.

DbgVariableLocation::extractFromMachineInstruction originally
returned a boolean indicating success. This change makes it return
an Expected<DbgVariableLocation> so we cannot try to access the fields
of the struct if they aren't valid.


https://reviews.llvm.org/D37279

Files:
  llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
  llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37279.113168.patch
Type: text/x-patch
Size: 6296 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170829/704d5883/attachment.bin>


More information about the llvm-commits mailing list