[PATCH] D37272: [cmake] Stop putting the revision info in LLVM_VERSION_STRING

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/CMakeLists.txt:207
-if( LLVM_APPEND_VC_REV )
-  add_version_info_from_vcs(PACKAGE_VERSION)
-endif()
----------------
I had to do a double-take to understand how this affects llvm-config.h.. but I see the function here appends to PACKAGE_VERSION which is then used in the header. ok.


================
Comment at: llvm/docs/CMake.rst:249
 
 **LLVM_APPEND_VC_REV**:BOOL
   Embed version control revision info (svn revision number or Git revision id).
----------------
I suppose it's not actually appending anything anymore, though.


https://reviews.llvm.org/D37272