[PATCH] D34560: Completelly disable git/svn version checking if not needed
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 29 11:51:34 PDT 2017
rnk added a comment.
In https://reviews.llvm.org/D34560#789101, @pcc wrote:
> Using `LLVM_APPEND_VC_REV` seems fine to me, but we probably want to update the documentation and most likely change the default because right now the VC revision affects ThinLTO cache invalidation, and we shouldn't silently use stale cache entries when clang is upgraded.
>
> @beanz any thoughts?
I think we can revert the change to the default value of LLVM_APPEND_VC_REV. The VCS revision doesn't need to be included in LLVM_VERSION_STRING because ThinLTO includes VCSRevision.h to add LLVM_REVISION into the hash.
https://reviews.llvm.org/D34560
More information about the llvm-commits
mailing list