[PATCH] D37266: [ThinLTO] Clean up stale alias import handling

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 29 11:07:13 PDT 2017


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Is it worth having the DEBUG output if no aliases are ever imported?

Could potentially rewrite this whole loop as:

  assert(none_of(SrcModule.aliases(), [&](GlobalAlias &GA) { if (!GA.hasName()) return false; return ImportGUIDs.count(GA.getGUID()); }) && "Unexpected alias in import list");

Dunno if that comes out more legible, though.


https://reviews.llvm.org/D37266





More information about the llvm-commits mailing list