[PATCH] D37163: [LICM] sink through non-trivially replicable PHI

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added inline comments.


================
Comment at: lib/Transforms/Scalar/LICM.cpp:803
+  Instruction *New;
+  auto It = SunkCopies.find(ExitBlock);
+  if (It != SunkCopies.end())
----------------
efriedma wrote:
> Do you need to do something to keep SunkCopies up to date?
This is to clone only one instruction per exit block and I couldn't think of a case where the same instruction is cloned several times in the same exit block. Please let me know if you can see any case where we need to update SunkCopies.


https://reviews.llvm.org/D37163