[PATCH] D36874: [ELF] - Mention -fPIC in some error messages

[George Rimar via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL312003: [ELF] - Mention -fPIC in some error messages. (authored by grimar).

Changed prior to commit:
  https://reviews.llvm.org/D36874?vs=113048&id=113095#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D36874

Files:
  lld/trunk/ELF/Relocations.cpp
  lld/trunk/test/ELF/dynamic-reloc-in-ro.s


Index: lld/trunk/ELF/Relocations.cpp
===================================================================
--- lld/trunk/ELF/Relocations.cpp
+++ lld/trunk/ELF/Relocations.cpp
@@ -566,7 +566,8 @@
     error("can't create dynamic relocation " + toString(Type) + " against " +
           (Body.getName().empty() ? "local symbol"
                                   : "symbol: " + toString(Body)) +
-          " in readonly segment" + getLocation<ELFT>(S, Body, RelOff));
+          " in readonly segment; recompile object files with -fPIC" +
+          getLocation<ELFT>(S, Body, RelOff));
     return Expr;
   }
 
Index: lld/trunk/test/ELF/dynamic-reloc-in-ro.s
===================================================================
--- lld/trunk/test/ELF/dynamic-reloc-in-ro.s
+++ lld/trunk/test/ELF/dynamic-reloc-in-ro.s
@@ -2,9 +2,9 @@
 // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
 // RUN: not ld.lld %t.o -o %t.so -shared 2>&1 | FileCheck %s
 
-// CHECK: can't create dynamic relocation R_X86_64_64 against local symbol in readonly segment
-// CHECK: >>> defined in {{.*}}.o
-// CHECK: >>> referenced by {{.*}}.o:(.text+0x0)
+// CHECK:      can't create dynamic relocation R_X86_64_64 against local symbol in readonly segment; recompile object files with -fPIC
+// CHECK-NEXT: >>> defined in {{.*}}.o
+// CHECK-NEXT: >>> referenced by {{.*}}.o:(.text+0x0)
 
 foo:
 .quad foo


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36874.113095.patch
Type: text/x-patch
Size: 1392 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170829/746a5a1f/attachment.bin>