[PATCH] D36841: [SimplifyCFG] Fix for PR34219: Preserve alignment after merging conditional stores.
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 29 07:53:06 PDT 2017
ABataev added inline comments.
================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:2969
PStore->getAAMetadata(AAMD, /*Merge=*/false);
PStore->getAAMetadata(AAMD, /*Merge=*/true);
SI->setAAMetadata(AAMD);
----------------
ABataev wrote:
> efriedma wrote:
> > efriedma wrote:
> > > This looks weird; why are we calling "PStore->getAAMetadata" twice?
> > No comment on the getAAMetadata() calls?
> I don't know what's going here, it is another problem. I just want to fix one PR here.
Most probably, it is a copy-paste error. Must be
```
PStore->getAAMetadata(AAMD, /*Merge=*/false);
QStore->getAAMetadata(AAMD, /*Merge=*/true);
```
https://reviews.llvm.org/D36841
More information about the llvm-commits
mailing list