[PATCH] D37153: [LoopUnroll] Properly update loop structure in case of successful peeling
Michael Zolotukhin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 28 17:44:19 PDT 2017
mzolotukhin added a comment.
> I added a cl::opt...
You seemed to forget to use it in the test though :)
I would also give basic blocks and variables more meaningful names (specifically, I'd rename header and preheader blocks to show clearer, what happens in the test).
Michael
================
Comment at: llvm/trunk/test/Transforms/LoopUnroll/pr33437.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -loop-unroll %s -S | FileCheck %s
+
----------------
Won't `opt %s -S` overwrite the input file with the output?
Repository:
rL LLVM
https://reviews.llvm.org/D37153
More information about the llvm-commits
mailing list