[PATCH] D36907: [codeview] support more DW_OPs for more complete debug info
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 28 16:20:51 PDT 2017
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.h:41
+ /// Register+Offset point at the location.
+ int InMemory : 1;
+
----------------
Make this `unsigned`, otherwise it will only store the values 0 and -1, which can be confusing from time to time.
https://reviews.llvm.org/D36907
More information about the llvm-commits
mailing list