[PATCH] D37233: [llvm-pdbutil] Print detailed S_UDT stats

[Bob Haarman via Phabricator via llvm-commits]

inglorion accepted this revision.
inglorion added a comment.
This revision is now accepted and ready to land.

Mostly lgtm; please take a look at the couple of inline comments before landing.



================
Comment at: llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp:624
+
+  return llvm::all_of(S, [](char C) { return std::isalnum(C); });
+}
----------------
Underscores are good, too, right?


================
Comment at: llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp:665
+  if (!File.hasPDBGlobalsStream()) {
+    P.printLine("- Error: globals stream not present");
+    return Error::success();
----------------
Consider changing the wording here so that we don't print "Error" but return success. Maybe "No S_UDT stats; globals stream not present"?


https://reviews.llvm.org/D37233