[PATCH] D36810: Minimal runtime for UBSan.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 13:51:21 PDT 2017


vitalybuka accepted this revision.
vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cc:23
+    // when sz==kMaxCallerPcs print "too many errors", but only when cmpxchg
+    // succeeds in order to not print it multiple times.
+    if (sz > 0 && sz < kMaxCallerPcs) {
----------------
This comment probably is unnecessary.
I was asking about early exit, not about "too many errors" in particular.


https://reviews.llvm.org/D36810





More information about the llvm-commits mailing list