[PATCH] D37226: [zorg] [sanitizer] Update i686->i386 to match rename in compiler-rt

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 13:01:01 PDT 2017


mgorny added inline comments.


================
Comment at: zorg/buildbot/builders/sanitizers/buildbot_android.sh:68
 build_android_ndk arm arm
-build_android_ndk i686 x86
+build_android_ndk i386 x86
 
----------------
eugenis wrote:
> In fact, this might be wrong.
> Ndk arch should be i686, unlike the standalone toolchain path.
FWICS ndk arch is actually 'x86' (the second argument). The first seems to be used only to construct the build directory path.


================
Comment at: zorg/buildbot/builders/sanitizers/buildbot_android.sh:80
 # Testing armv7 instead of plain arm to work around
 # https://code.google.com/p/android/issues/detail?id=68779
+test_android i386:x86 aarch64:arm64-v8a arm:armeabi-v7a
----------------
eugenis wrote:
> Btw could you move this comment to line 72?
Sure, will do.


Repository:
  rL LLVM

https://reviews.llvm.org/D37226





More information about the llvm-commits mailing list