[compiler-rt] r311911 - Proper dependency check for clang in compiler_rt.

George Karpenkov via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 12:39:06 PDT 2017


Author: george.karpenkov
Date: Mon Aug 28 12:39:05 2017
New Revision: 311911

URL: http://llvm.org/viewvc/llvm-project?rev=311911&view=rev
Log:
Proper dependency check for clang in compiler_rt.

 - Not having a dependency does not work in standalone build, as Clang does not exist.
 - if (TARGET clang) check is useless, as it is order-dependent,
   and Clang may not be registered yet.

Differential Revision: https://reviews.llvm.org/D37228

Modified:
    compiler-rt/trunk/cmake/Modules/CompilerRTCompile.cmake

Modified: compiler-rt/trunk/cmake/Modules/CompilerRTCompile.cmake
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/Modules/CompilerRTCompile.cmake?rev=311911&r1=311910&r2=311911&view=diff
==============================================================================
--- compiler-rt/trunk/cmake/Modules/CompilerRTCompile.cmake (original)
+++ compiler-rt/trunk/cmake/Modules/CompilerRTCompile.cmake Mon Aug 28 12:39:05 2017
@@ -136,7 +136,7 @@ macro(clang_compiler_add_cxx_check)
       COMMAND bash -c "${CMD}"
       COMMENT "Checking that just-built clang can find C++ headers..."
       VERBATIM)
-    if (TARGET clang)
+    if (NOT COMPILER_RT_STANDALONE_BUILD)
       ADD_DEPENDENCIES(CompilerRTUnitTestCheckCxx clang)
     endif()
   endif()




More information about the llvm-commits mailing list