[PATCH] D37220: [DAG] Bound loop dependence check in merge optimization.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 28 12:24:50 PDT 2017
efriedma added a subscriber: chandlerc.
efriedma added a comment.
I guess this is okay...? Adding arbitrary limits isn't nice, but I don't know what a nice solution looks like here. (Probably we should be using a different algorithm to find stores to merge; maybe something more like a DAG scheduling algorithm.)
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12795
+ // stores from which worklist nodes come from in a similar way to
+ // TokenFactor simplfication.
+
----------------
This helps in cases where there's a common ancestor nearby... but does that actually cover all interesting cases?
https://reviews.llvm.org/D37220
More information about the llvm-commits
mailing list