[PATCH] D37123: [dwarfdump] Pretty print location expressions and location lists

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

In https://reviews.llvm.org/D37123#854201, @rnk wrote:

> I think the remaining concerns are:
>
> 1. Should we split the location list base address change into another patch


Typically the answer to the question whether we should split up a patch is always yes, but I'm fine either way.

> 2. Should we try to avoid one-time dynamic initialization for the DW_OP description table

Would it perhaps make sense to initialize the table from the macros in `Dwarf.def`?

> 3. Should we remove the "OP_" prefix

I think we should implement two behaviors: When DumpOptions::Brief is set, we should print expressions with DW_OP_ stripped and registers in human-readable form, e.g.: `rdi+42, deref, stack-value`, otherwise it should print the full expression, e.g.: `DW_OP_breg1, DW_OP_constu 42, DW_OP_deref, DW_OP_stack_value`.

(And at some point soon, I'll upload a patch to make brief the default instead of verbose).

> In general, I'd like to defer anything that people feel can wait, so that I can minimize the amount of time that I'm carrying this patch locally. It has a high risk for conflicts vs. people adding new dwarf tests, and I've already put in a lot of work updating the test suite.

Makes sense!


https://reviews.llvm.org/D37123