[PATCH] D36986: [ELF] Generate symbol assignments for predefined symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:205
 
+  addPredefinedSymbolAssignments();
+
----------------
Can you briefly mention as a comment about what this function is supposed to do?


================
Comment at: ELF/Writer.cpp:927
 
+template <class ELFT> void Writer<ELFT>::addPredefinedSymbolAssignments() {
+  PhdrEntry *Last = nullptr;
----------------
Can you add a comment to explain what this function is supposed to do?


Repository:
  rL LLVM

https://reviews.llvm.org/D36986