[PATCH] D37176: Create PHI node for the return value only when the return value has uses.

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 10:25:58 PDT 2017

Previous message: [PATCH] D37176: Create PHI node for the return value only when the return value has uses.
Next message: [PATCH] D37176: Create PHI node for the return value only when the return value has uses.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

xur added a comment.

Thanks for the fix.

LGTM, but I agree with David that it's preferable to put the check inside insertCallRetPHI() (around isVoidTy()).


https://reviews.llvm.org/D37176

Previous message: [PATCH] D37176: Create PHI node for the return value only when the return value has uses.
Next message: [PATCH] D37176: Create PHI node for the return value only when the return value has uses.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list