[PATCH] D37193: Add NetBSD specific version of sanitizer_platform_limits_posix

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 09:30:03 PDT 2017


kcc added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:4117
   if (res >= 0) {
+#if SANITIZER_NETBSD
+    unsigned sz = struct_shminfo_sz;
----------------
can you use if (SANITIZER_NETBSD) here? 


================
Comment at: lib/sanitizer_common/sanitizer_linux.h:21
 #include "sanitizer_posix.h"
+#if SANITIZER_NETBSD
+#include "sanitizer_platform_limits_netbsd.h"
----------------
No like this. 
Instead, please guard the entire file if #if SANITIZER_NETBSD and then include the file w/o #if 


Repository:
  rL LLVM

https://reviews.llvm.org/D37193





More information about the llvm-commits mailing list