[PATCH] D37176: Create PHI node for the return value only when the return value has uses.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 28 08:49:50 PDT 2017


davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:592
 
-  insertCallRetPHI(Inst, NewInst, DirectCallee);
+  if (!Inst->use_empty())
+    insertCallRetPHI(Inst, NewInst, DirectCallee);
----------------
may be wrap this check inside the function just as other checks?


https://reviews.llvm.org/D37176





More information about the llvm-commits mailing list