t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. I think the issues have been basically resolved here. The assertion can't hurt. LGTM! Repository: rL LLVM https://reviews.llvm.org/D37030