[PATCH] D37116: Enable building LLVMgold.dll under mingw.

[Stephen Hines via Phabricator via llvm-commits]

srhines added a comment.

In https://reviews.llvm.org/D37116#853740, @chapuni wrote:

> @srhines, BUILD_SHARED_LIBS was working for mingw with Clang/LLVM plugins, at least till June.
>  (I suspended running mingw builder then)
>  On mingw, CMake's "add_library(MODULE)" requires dependent submodules by target_link_libraries().
>  It's the same if you are linking your plugin with bit LLVM.dll.


We still have to try this out on a Windows machine to make sure that all of LTO is working, but getting LLVMgold.dll building is the first step. Perhaps we aren't configuring other aspects correctly, but I still think it is better to just have one LLVM.dll instead of multiple .dll files from a packaging/distribution standpoint.

> FYI, I had a stale patch for mingw to work as "Linking plugin module with unnamed DLL by lazyload, to resolve symbols provided by parent EXE". Are you interested?

I'm not sure I understand this. I really stopped working on windows ~7 years ago, and didn't even do that much Windows-specific stuff at that time either. For the Android NDK, we pretty much just ship what we can on Windows, although we are trying to do a better job now. That's why this patch is important to me.


https://reviews.llvm.org/D37116