[PATCH] D37118: [ARM] Tidy-up ARMAsmParser. NFC.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 27 03:26:14 PDT 2017
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, using MRI->getSubReg seems much better! Thanks @asb for pointing that out, I assume there is still more potential for re-using more general functions in the ARM backend
================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:268
+ // Return the low-subreg of a given Q register.
+ unsigned getDRegFromQReg(unsigned QReg) {
+ return MRI->getSubReg(QReg, ARM::dsub_0);
----------------
this could be a const function I think?
https://reviews.llvm.org/D37118
More information about the llvm-commits
mailing list