[PATCH] D37171: [cfi] Avoid branch veneers in jump tables when possible.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 18:20:42 PDT 2017


pcc added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:1121
+  if (ArmCount == ThumbCount)
+    return ModuleArch;
+  return ArmCount > ThumbCount ? Triple::arm : Triple::thumb;
----------------
It seems arbitrary for the module architecture to be the tie breaker. With full LTO I think it will just be the same architecture as the first (or maybe last?) input file. I'd remove this part.


https://reviews.llvm.org/D37171





More information about the llvm-commits mailing list