[PATCH] D37164: [ARM] Fix bug in ARMLoadStoreOptimizer when kill flags are missing.
    Eli Friedman via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Aug 25 15:22:21 PDT 2017
    
    
  
efriedma added a comment.
If I understand correctly, the original code was checking for the kill flags just to short-circuit the if statement more quickly?
================
Comment at: lib/Target/ARM/ARMLoadStoreOptimizer.cpp:1660
+    // register before the second load reads it.
+    if (isLd && (TRI->regsOverlap(EvenReg, BaseReg))) {
       assert(!TRI->regsOverlap(OddReg, BaseReg));
----------------
Extra parens.
https://reviews.llvm.org/D37164
    
    
More information about the llvm-commits
mailing list