[PATCH] D29935: [RISCV 13/n] Codegen for conditional branches

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 14:33:49 PDT 2017


asb added inline comments.


================
Comment at: lib/Target/RISCV/RISCVInstrInfo.td:63
 // A 13-bit signed immediate where the least significant bit is zero.
-def simm13_lsb0 : Operand<i32> {
+def simm13_lsb0 : Operand<OtherVT> {
   let ParserMatchClass = SImmAsmOperand<13, "Lsb0">;
----------------
apazos wrote:
> Maybe these td file changes should move to a separate patch?
I think they belong here, as the change is made necessary by the codegen implementation. Or perhaps I'm misunderstanding your concern?


https://reviews.llvm.org/D29935





More information about the llvm-commits mailing list