[PATCH] D29938: [RISCV 16/n] Support and tests for a variety of additional LLVM IR constructs

[Ana Pazos via Phabricator via llvm-commits]

apazos added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:411
   } else if (isa<ExternalSymbolSDNode>(Callee)) {
-    report_fatal_error(
-        "lowerExternalSymbol, needed for lowerCall, not yet handled");
+    Callee = lowerExternalSymbol(Callee, DAG);
   }
----------------
code standard reminder: another instance of using {} with one line statement.


================
Comment at: test/CodeGen/RISCV/sext-zext-trunc.ll:177
+; CHECK-LABEL: trunc_i8_to_i1
+  %1 = trunc i8 %a to i1
+  ret i1 %1
----------------
Nothing is being tested here right? if you need to check a sequence you can use CHECK-NEXT


https://reviews.llvm.org/D29938