[PATCH] D37093: [coroutines] Promote cleanup.dest.slot-like allocas to registers to avoid storing them in the coroutine frame

[Eric Niebler via Phabricator via llvm-commits]

eric_niebler added inline comments.


================
Comment at: lib/Transforms/Coroutines/CoroFrame.cpp:789
+  // the entry node.
+  for (BasicBlock::iterator I = BB.begin(), E = --BB.end(); I != E; ++I)
+    if (auto *AI = dyn_cast<AllocaInst>(I))
----------------
Knowing nothing about how this code works, it seems strange to me that you are ignoring the last instruction in the basic block, but the comment says you're looking at all instructions.


https://reviews.llvm.org/D37093