[PATCH] D37118: [ARM] Tidy-up ARMAsmParser. NFC.

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 10:42:44 PDT 2017


javed.absar added a comment.

In https://reviews.llvm.org/D37118#852522, @asb wrote:

> Why not use MCRegisterInfo::getSubReg for this purpose, thus avoiding repeating information that's already present in ARMRegisterInfo.td? `MRI->getSubReg(QReg, ARM::dsub_0)` should replace the functionality of getDRegFromQReg.


That's a good idea. Have done that instead. I don't see other uses of this function otherwise moving it to Utils as earlier would have been better i think.


https://reviews.llvm.org/D37118





More information about the llvm-commits mailing list