[PATCH] D37149: Shorten filenames of tests (-with-calls to -wcalls)

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 25 08:32:36 PDT 2017


krytarowski created this revision.
krytarowski added a project: Sanitizers.
Herald added subscribers: mgorny, kubamracek.

The NetBSD's 8(beta) versions of kernel functions to retrieve
program name (vnode to path translator) and process memory
map has internal limit of processing file names with maximum
of 31 characters.

Filenames like Asan-x86_64-with-calls-Noinst-Test break this
limit and affect tests. Rename "-with-calls" to "-wcalls".

This changes fixes all issues for the Address Sanitizer test
target (check-asan) on the current NetBSD support caused
by long filenames.

Sponsored by <The NetBSD Foundation>


Repository:
  rL LLVM

https://reviews.llvm.org/D37149

Files:
  lib/asan/tests/CMakeLists.txt


Index: lib/asan/tests/CMakeLists.txt
===================================================================
--- lib/asan/tests/CMakeLists.txt
+++ lib/asan/tests/CMakeLists.txt
@@ -265,7 +265,9 @@
       FOLDER "Compiler-RT Runtime tests")
 
     add_asan_tests(${arch} ${ASAN_TEST_RUNTIME} KIND "-inline")
-    add_asan_tests(${arch} ${ASAN_TEST_RUNTIME} KIND "-with-calls"
+    # wcalls stands for "with-calls", keep shorter name this is required by
+    # some OSes for certain features to work correctly
+    add_asan_tests(${arch} ${ASAN_TEST_RUNTIME} KIND "-wcalls"
       CFLAGS -mllvm -asan-instrumentation-with-call-threshold=0)
   endforeach()
 endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37149.112696.patch
Type: text/x-patch
Size: 659 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170825/f8ffecf3/attachment.bin>


More information about the llvm-commits mailing list