[PATCH] D37127: [dsymutil] Don't mark forward declarations as canonical.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere updated this revision to Diff 112660.
JDevlieghere marked 5 inline comments as done.
JDevlieghere added a comment.

Thanks for the review @aprantl! About the comment for the `Incomplete` member: can this strictly occur for members or has this a broader scope?


Repository:
  rL LLVM

https://reviews.llvm.org/D37127

Files:
  test/tools/dsymutil/Inputs/odr-fwd-declaration/1.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration/2.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration/3.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration2/1.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration2/2.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration2/3.o
  test/tools/dsymutil/X86/odr-fwd-declaration.cpp
  test/tools/dsymutil/X86/odr-fwd-declaration2.cpp
  tools/dsymutil/DwarfLinker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37127.112660.patch
Type: text/x-patch
Size: 13210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170825/a9bf3c47/attachment.bin>