[PATCH] D37128: [unittests] Limit reverse iteration test to only reverse iteration builds

[Grang, Mandeep Singh via llvm-commits]

I think maintaining an *expected* order for pointer-like keys may not be 
the correct way of doing this. We would need a way to make the expected 
order independent of the hashing function.

On 8/24/2017 5:26 PM, Grang, Mandeep Singh via llvm-commits wrote:
>
> The problem is not the reversal of the expected order. The problem is 
> that the *expected* order for pointer-like keys may differ based on 
> how they are hashed.
>
> The hashing order may be machine/platform/environment dependent.
>
> --Mandeep
>
>
> On 8/24/2017 5:17 PM, David Blaikie wrote:
>> Doesn't the test only reverse the expected order if reverse iteration 
>> is enabled? So why is this failing on a forward iteration build?
>>
>> On Thu, Aug 24, 2017 at 5:13 PM Mandeep Singh Grang via Phabricator 
>> <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
>>
>>     mgrang created this revision.
>>
>>     This test causes failures in forward iteration builds. This is
>>     because we have hard-coded
>>     the expected order of iteration of supported containers.
>>
>>
>>     Repository:
>>       rL LLVM
>>
>>     https://reviews.llvm.org/D37128
>>
>>     Files:
>>       unittests/Support/ReverseIterationTest.cpp
>>
>>
>>     Index: unittests/Support/ReverseIterationTest.cpp
>>     ===================================================================
>>     --- unittests/Support/ReverseIterationTest.cpp
>>     +++ unittests/Support/ReverseIterationTest.cpp
>>     @@ -16,6 +16,8 @@
>>      #include "llvm/Support/ReverseIteration.h"
>>      #include "gtest/gtest.h"
>>
>>     +#if LLVM_ENABLE_REVERSE_ITERATION
>>     +
>>      using namespace llvm;
>>
>>      TEST(ReverseIterationTest, DenseMapTest1) {
>>     @@ -109,3 +111,5 @@
>>        for (auto iter = Set.begin(), end = Set.end(); iter != end;
>>     iter++, ++i)
>>          ASSERT_EQ(*iter, IterPtrs[i]);
>>      }
>>     +
>>     +#endif
>>
>>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170824/e2ee513e/attachment.html>