[PATCH] D36841: [SimplifyCFG] Fix for PR34219: Preserve alignment after merging conditional stores.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:2969
   PStore->getAAMetadata(AAMD, /*Merge=*/false);
   PStore->getAAMetadata(AAMD, /*Merge=*/true);
   SI->setAAMetadata(AAMD);
----------------
This looks weird; why are we calling "PStore->getAAMetadata" twice?


================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:2972
+  if (unsigned Alignment = PStore->getAlignment())
+    SI->setAlignment(Alignment);
 
----------------
What happens if PStore and QStore have different alignment?


https://reviews.llvm.org/D36841