[PATCH] D37127: [dsymutil] Don't mark forward declarations as canonical.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.

This patch completes the work done by Frederic Riss (@friss) to
addresses dsymutil incorrectly considering forward declaration as
canonical during uniquing. This resulted in references to the forward
declaration even after the definition was encountered.

In addition to the test provided by Alexander Shaposhnikov (@alexshap)
in https://reviews.llvm.org/D29609, I added another test to cover several scenarios that were
mentioned in his conversation with Fred. We now also check that uniquing
still occurs after the definition was encountered.

For more context please refer to https://reviews.llvm.org/D29609


Repository:
  rL LLVM

https://reviews.llvm.org/D37127

Files:
  test/tools/dsymutil/Inputs/odr-fwd-declaration/1.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration/2.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration/3.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration2/1.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration2/2.o
  test/tools/dsymutil/Inputs/odr-fwd-declaration2/3.o
  test/tools/dsymutil/X86/odr-fwd-declaration.cpp
  test/tools/dsymutil/X86/odr-fwd-declaration2.cpp
  tools/dsymutil/DwarfLinker.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37127.112633.patch
Type: text/x-patch
Size: 13337 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170824/4c120bdb/attachment.bin>