[PATCH] D37124: AMDGPU: Correct operand types for v_mad_mix*

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 15:36:29 PDT 2017


arsenm created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl.

These aren't really packed instructions, so the default
op_sel_hi should be 0 since this indicates a conversion.
The operand types are scalar values that behave similar
to an f16 scalar that may be converted to f32.

      

Doesn't change the default printing for op_sel_hi, just
the parsing.

Is there a script to update test/MC/AMDGPU/gfx9_asm_all.s? I got tired of manually updating all of the cases in it so it fails now.


https://reviews.llvm.org/D37124

Files:
  lib/Target/AMDGPU/AMDGPU.td
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/SIInstrInfo.td
  lib/Target/AMDGPU/VOP3PInstructions.td
  lib/Target/AMDGPU/VOPInstructions.td
  test/MC/AMDGPU/gfx9_asm_all.s
  test/MC/AMDGPU/vop3p.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37124.112623.patch
Type: text/x-patch
Size: 19898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170824/b7922b49/attachment.bin>


More information about the llvm-commits mailing list