[PATCH] D37119: lld-link: Use opt:noref by default in debug builds

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 13:49:25 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/Driver.cpp:844
+
+    // msvc linker uses /opt:noref by default in debug builds
+    Config->DoGC = false;
----------------
It is a bit odd that you mentioned only /opt:noref. I'd probably write a comment:

  // /debug implies /opt:noref and /opt:noicf. This is compatible with MSVC.


https://reviews.llvm.org/D37119





More information about the llvm-commits mailing list